[Cyberduck-trac] [Cyberduck] #933: Bookmark with '/' in nickname can't be saved to Finder

[Cyberduck]

#933: Bookmark with '/' in nickname can't be saved to Finder
----------------------+-----------------------------------------------------
 Reporter:  jamescat  |       Owner:  dkocher  
     Type:  defect    |      Status:  new      
 Priority:  normal    |   Milestone:           
Component:  core      |     Version:  2.6.2    
 Severity:  normal    |    Keywords:  bookmarks
----------------------+-----------------------------------------------------
 When creating a bookmark with a '/' character in the nickname field,
 Cyberduck will fail to allow you to drag the file to the Finder.

 Unfortunately, it does not give any indication that it has failed, it
 simply doesn't create the file.

 ''(Additional testing shows that if a folder matching the pre-/ portion of
 the nickname exists, Cyberduck will create a file inside that folder with
 '''only''' the post-/ portion of the nickname as the bookmark filename. -
 I.e. Cyberduck is not escaping path components well in its file
 creation/naming routine.)''

 The fix would appear to simply be checking for the '/' character in
 nicknames before completing the drag operation and converting any and all
 of them that are found into ':' characters (which the Finder represents as
 '/' to the user) so that the bookmark is created in the expected location
 with it's appropriate name.

 ''(Bookmarks with ':' characters might ought to be a special case too due
 to their special history as path separators in old Mac OS versions... but
 they appear to work just fine as is and merely appear in the Finder with a
 '/' instead of the ':' as might be expected anyway. So it isn't really
 "necessary" to handle them in any special way.)''

 Optionally, if there is some exceptional problem I haven't foreseen in
 fixing this, then there should at the very least be a warning message
 generated by Cyberduck if dragging the bookmark fails. Currently,
 absolutely nothing happens at the end of the drag operation, and that is
 not good for the user experience.

-- 
Ticket URL: <http://trac.cyberduck.ch/ticket/933>
Cyberduck <http://cyberduck.ch>
FTP and SFTP Browser for Mac OS X.