[Cyberduck-trac] [Cyberduck] #7736: Dav -- Overwrite:T header is not specified after confirming overwrite

Cyberduck trac at trac.cyberduck.io
Wed Jan 15 02:14:51 UTC 2014


#7736: Dav -- Overwrite:T header is not specified after confirming overwrite
----------------------------+------------------------
 Reporter:  matthew bellew  |         Owner:  dkocher
     Type:  defect          |        Status:  new
 Priority:  normal          |     Milestone:  4.4.4
Component:  webdav          |       Version:  4.4.3
 Severity:  normal          |    Resolution:
 Keywords:                  |  Architecture:
 Platform:  Mac OS X 10.9   |
----------------------------+------------------------

Comment (by matthew bellew):

 This seems to fix it.  If you want to explicitly track whether the user
 has hit "overwrite" I suppose that would go in the TransferOptions, but
 that's not passed down this far.



 Index: source/ch/cyberduck/core/dav/DAVWriteFeature.java
 IDEA additional info:
 Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
 <+>UTF-8
 ===================================================================
 --- source/ch/cyberduck/core/dav/DAVWriteFeature.java   (revision 14207)
 +++ source/ch/cyberduck/core/dav/DAVWriteFeature.java   (revision )
 @@ -41,7 +41,7 @@
  import com.github.sardine.impl.handler.ETagResponseHandler;

  /**
 - * @version $Id: DAVWriteFeature.java 14205 2014-01-15 01:32:31Z dkocher
 $
 + * @version $Id: DAVWriteFeature.java 14205 2014-01-13 22:33:09Z dkocher
 $
   */
  public class DAVWriteFeature extends AbstractHttpWriteFeature<String>
 implements Write {

 @@ -69,6 +69,7 @@
                      status.getCurrent(), status.getLength() - 1,
 status.getLength())
              );
          }
 +        headers.put("Overwrite","T");
          if(expect) {
              headers.put(HTTP.EXPECT_DIRECTIVE, HTTP.EXPECT_CONTINUE);
          }

-- 
Ticket URL: <https://trac.cyberduck.io/ticket/7736#comment:1>
Cyberduck <http://cyberduck.io>
Libre FTP, SFTP, WebDAV, S3 & OpenStack Swift browser for Mac and Windows


More information about the Cyberduck-trac mailing list