[Cyberduck-trac] [Cyberduck] #185: Slow SFTP transfers
Cyberduck
trac at trac.cyberduck.ch
Tue Nov 9 19:40:40 CET 2010
#185: Slow SFTP transfers
---------------------------------------+------------------------------------
Reporter: wout.mertens@… | Owner: dkocher
Type: enhancement | Status: closed
Priority: high | Milestone: 4.0
Component: sftp | Version: 3.5
Severity: major | Resolution: fixed
Keywords: | Platform: Mac OS X 10.6
Architecture: Intel |
---------------------------------------+------------------------------------
Comment (by caeies):
Yeah, looks far much better :) (i've done an update in my sources)
I'm near the maximum download speed of my ADSL line ... Looks good to me.
I've just take a quick look in your diff, and notice A potential bug (but
I'm not sure on that) :
{{{
1171 for(OutstandingRequest r : pendingQueue.values())
{
1172 // Server offset should take pending requests
into account.
1173 serverOffset += r.len;
1174 }
}}}
Doing so, you assume that each packet come one after one, when parallelism
doesn't allow you to do so. IIRC the offset information is in the
received packet (but I'm not an expert, just looking at what sftp does).
What do you think ?
Regards, and thanks for this fix, users will really be happy !
Caeies.
--
Ticket URL: <http://trac.cyberduck.ch/ticket/185#comment:54>
Cyberduck <http://cyberduck.ch>
Open source FTP, SFTP, WebDAV, Cloud Files, Google Docs & Amazon S3 Browser for Mac & Windows.
More information about the Cyberduck-trac
mailing list